UNADDR in __from_strstr_to_strchr in ipc_tests

[derekbruening]

From bruen...@google.com on October 06, 2011 19:11:54

split from issue #613 un-replaced optimized string routine unaddr seen when run with this particular ends-up-as-no-test gtest filter, in either cygwin or cmd:
% PATH=/c/src/chromium/depot_tools:$PATH tools/valgrind/chrome_tests.bat --build_dir build/Release -t ipc --tool drmemory_full --gtest_filter="IPCSyncChannelTest.Simple"
UNADDRESSABLE ACCESS: reading 0x00f4f04b-0x00f4f04c 1 byte(s) within 0x00f4f048-0x00f4f04c
#0 __from_strstr_to_strchr [f:\dd\vctools\crt_bld\SELF_X86\crt\src\INTEL\strchr.asm:142]
#1 testing::internal::UnitTestOptions::FilterMatchesTest [testing\gtest\src\gtest.cc:501]
Note: @0:00:03.426 in thread 5388
Note: next higher malloc: 0x00f4f858-0x00f4f868
Note: refers to 1 byte(s) beyond last valid byte in prior malloc
Note: prev lower malloc: 0x00f4f030-0x00f4f04b
Note: instruction: mov 0xfffffffc(%edx) -> %eax

Original issue: http://code.google.com/p/drmemory/issues/detail?id=617

[derekbruening]

From zhao...@google.com on October 06, 2011 17:15:00

__from_strstr_to_strchr is part of strchr

ipc_tests!strchr:
01017270 33c0 xor eax,eax
01017272 8a442408 mov al,[esp+0x8]
ipc_tests!__from_strstr_to_strchr:
01017276 53 push ebx
01017277 8bd8 mov ebx,eax
01017279 c1e008 shl eax,0x8
0101727c 8b542408 mov edx,[esp+0x8]
01017280 f7c203000000 test edx,0x3

It looks like there are multiple strchr but DrMem only replaced one.

01017270 ipc_tests!strchr (unsigned char_, unsigned char)
010339b0 ipc_tests!strchr (char_, int)

[derekbruening]

From zhao...@google.com on November 01, 2011 08:51:19

This issue was closed by revision r582 .

Status: Fixed