Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspend all threads on takeover, for duration of DR init, for all injection paths #1305

Open
derekbruening opened this issue Nov 28, 2014 · 1 comment

Comments

@derekbruening
Copy link
Contributor

From bruen...@google.com on October 25, 2013 14:46:17

Xref issue #1304 .

We obviously want to do this for externally-triggered attach (xref issue
38 , issue #725 ). Today's internally-triggered attach ( issue #722 ) assumes
the app has called our init routine up front and that we just need to take
over all the threads later.

Even for regular injection, to handle corner cases of early threads, we
should suspend all the other threads for the duration of DR's init to
satisfy the parts of the init process that assume there are no races.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1305

@derekbruening
Copy link
Contributor Author

For the start/stop API, we would want to only support combined
dr_app_setup_and_start(). We would also have to refactor the init and
takeover code to do enough initialization that we can send signals to
threads for takeover, then finish initialization, and only then resume the
threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant