Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instr_get_opcode(ins) doesn't support NEON and VFP instructions #2624

Closed
yuhao opened this issue Aug 30, 2017 · 4 comments
Closed

instr_get_opcode(ins) doesn't support NEON and VFP instructions #2624

yuhao opened this issue Aug 30, 2017 · 4 comments

Comments

@yuhao
Copy link

yuhao commented Aug 30, 2017

Instructions like fmul (vector version) or vmla.f32 are not supported. Is there a plan?

@egrimley
Copy link
Contributor

FMUL is AArch64 and currently not handled by the decoder. Of the AArch64 instructions that operate on FP/SIMD registers only load/store instructions are decoded, though it should still be possible to execute any instruction. I don't seem to be able to find a specific issue for completing the AArch64 decoder, though there are related issues, such as #2440 and #2443, and there's #1569, of course.

VMLA.F32 is AArch32 and should work, I think.

If "fmul" is a typo for "vmul", please label this issue with OpSys-ARM and explain what doesn't work.

@derekbruening
Copy link
Contributor

Right, please clarify which architecture you are looking at. All Advanced SIMD and floating point instructions for AArch32 in ARMv8, including vmla.f32, are supported in DR's IR.

@yuhao
Copy link
Author

yuhao commented Aug 30, 2017

I meant FMUL in AArch64. I suppose this is not a bug, but I was curious if the support for AArch64 will be extended to non load/store instructions?

@egrimley
Copy link
Contributor

I've created #2626; I hope it's not a duplicate. I'll close this one for now. It can be reopened if there is a problem with vmla.f32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants