Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool.drcacheoff.purestatic fails to build #7260

Open
edeiana opened this issue Feb 7, 2025 · 0 comments · May be fixed by #7261
Open

tool.drcacheoff.purestatic fails to build #7260

edeiana opened this issue Feb 7, 2025 · 0 comments · May be fixed by #7261
Assignees
@edeiana
Labels
Component-Build Component-Tests Google-Affecting

Comments

@edeiana
Copy link
Contributor

edeiana commented Feb 7, 2025

tool.drcacheoff.purestatic fails to build in some machine configuration (e.g., internally at Google).
The failure happens at link time due to missing symbols in lz4 that requires xxhash.

/usr/bin/ld: (.text+0x23b9): undefined reference to `XXH32_digest'
/usr/bin/ld: (.text+0x2878): undefined reference to `XXH32'
/usr/bin/ld: (.text+0x2a2a): undefined reference to `XXH32_reset'
/usr/bin/ld: (.text+0x2a72): undefined reference to `XXH32_reset'
/usr/bin/ld: (.text+0x2b1a): undefined reference to `XXH32_update'
/usr/bin/ld: (.text+0x2b68): undefined reference to `XXH32_update'
/usr/bin/ld: (.text+0x2b99): undefined reference to `XXH32_update'
/usr/bin/ld: (.text+0x2bb0): undefined reference to `XXH32_update'

To fix it, we need to statically link xxhash after lz4 to respect dependencies.

We should also update our doc, stating that libxxhash-dev is now required to build some tests.
@edeiana edeiana self-assigned this Feb 7, 2025
edeiana added a commit that referenced this issue Feb 8, 2025
@edeiana
i#7260: tool.drcacheoff.purestatic bug fix
947edd4 
`tool.drcacheoff.purestatic` fails to build due to `libxxhash` missing.
This library is used by `liblz4` in some cases, and must be statically
linked when building the `tool.drcacheoff.purestatic` app, which we use
in some tests.

We update the doc adding `libxxhash-dev` to the list of packages that
need to be installed to build DynamoRIO on Linux.

Note: `tool.drcacheoff.purestatic` is currently only built in x64 Linux
hosts.

Fixes #7260
@edeiana edeiana linked a pull request Feb 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edeiana edeiana

Labels
Component-Build Component-Tests Google-Affecting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#7260: tool.drcacheoff.purestatic bug fix DynamoRIO/dynamorio
1 participant
@edeiana