Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: CDAT Migration Phase 2: Make _get_metrics_by_region() a general function #775

Closed
3 tasks done
tomvothecoder opened this issue Jan 8, 2024 · 0 comments
Closed
3 tasks done

[Feature]: CDAT Migration Phase 2: Make _get_metrics_by_region() a general function #775

tomvothecoder opened this issue Jan 8, 2024 · 0 comments
Assignees
@tomvothecoder
Labels
cdat-migration-fy24 CDAT Migration FY24 Task enhancement
Milestone
FY24 Q2 (01/01/24...

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Jan 8, 2024 •
edited
Loading

Is your feature request related to a problem?

This change will make _get_metrics_by_region() a general function that can be used across sets.

Describe the solution you'd like

_get_metrics_by_region()

  • Move to utils/regrid.py
  • Rename to `subset_and_align_datasets()
  • Update return values and docstrings

Describe alternatives you've considered

No response

Additional context

No response
@tomvothecoder tomvothecoder added enhancement cdat-migration-fy24 CDAT Migration FY24 Task labels Jan 8, 2024
@tomvothecoder tomvothecoder self-assigned this Jan 8, 2024
@tomvothecoder tomvothecoder changed the title [Feature]: CDAT Migration Phase 2: Make lat_lon set _run_diags_2d() generalized [Feature]: CDAT Migration Phase 2: Make _get_metrics_by_region() a general function Jan 8, 2024
@tomvothecoder tomvothecoder mentioned this issue Jan 8, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomvothecoder tomvothecoder

Labels
cdat-migration-fy24 CDAT Migration FY24 Task enhancement
Projects
None yet
Milestone
FY24 Q2 (01/01/24 - 03/31/24)
Development

No branches or pull requests
1 participant
@tomvothecoder