Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support arbitrary regions #827

Open
forsyth2 opened this issue Jul 24, 2024 · 0 comments
Open

[Feature]: Support arbitrary regions #827

forsyth2 opened this issue Jul 24, 2024 · 0 comments
Labels
enhancement new feature New feature (will increment minor version)

Comments

@forsyth2
Copy link
Collaborator

Is your feature request related to a problem?

While we primarily want to support standardized regions for analysis, it may be useful to researchers to be able to define their own regions for ad-hoc analyses (e.g., diagnosing issues in a certain region in a high-resolution model).

Describe the solution you'd like

Add the ability for users to specify user-defined regions in the cfg rather than needing to actually change the e3sm_diags source code in https://github.com/E3SM-Project/e3sm_diags/blob/main/e3sm_diags/derivations/default_regions.py.

The primary complication I foresee with this is that regions is specified as a list of strings that default_regions.py then maps to actual regions, so the question is how to specify a region in a cfg. Perhaps it could be parsed from a string (e.g., latitude=(0.0, 45.0, "ccb"), longitude=(210.0, 310.0, "ccb") => "0.0,45.0,ccb,210.0,310.0,ccb")? At that point, it seems like another parameter would have to be introduced, something like user_defined_regions=.

Describe alternatives you've considered

Additional context

No response

@forsyth2 forsyth2 added enhancement new feature New feature (will increment minor version) labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature New feature (will increment minor version)
Projects
None yet
Development

No branches or pull requests

1 participant