Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminates redundant options in ncclimo/ncremap calls #569

Closed
3 tasks done
forsyth2 opened this issue Apr 5, 2024 · 1 comment · Fixed by #400
Closed
3 tasks done

Eliminates redundant options in ncclimo/ncremap calls #569

forsyth2 opened this issue Apr 5, 2024 · 1 comment · Fixed by #400
Assignees
Labels
semver: small improvement Small improvement (will increment patch version)

Comments

@forsyth2
Copy link
Collaborator

forsyth2 commented Apr 5, 2024

Request criteria

  • I searched the zppy GitHub Discussions to find a similar question and didn't find it.
  • I searched the zppy documentation.
  • This issue does not match the other templates (i.e., it is not a bug report, documentation request, feature request, or a question.)

Issue description

From #400 (comment):

Eliminate these options:
--mem_mb=0 (ncclimo/ncremap automatically supply this srun option)
--area=area (ncclimo automatically supplies "area" as the default name for the area variable)
It would be nice to clean-up these calls in 1.10.0.

@forsyth2 forsyth2 added the semver: small improvement Small improvement (will increment patch version) label Apr 5, 2024
@forsyth2 forsyth2 self-assigned this Apr 5, 2024
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Apr 9, 2024

@czender

--area=area (ncclimo automatically supplies "area" as the default name for the area variable)

That command is not actually hard-coded. The bash file actually has that value filled in via --area={{ area_nm }}. So, we should keep that as-is.

--mem_mb=0 (ncclimo/ncremap automatically supply this srun option)

Since this is literally a one-line change, I'm going to just include this as part of #400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: small improvement Small improvement (will increment patch version)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant