Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Separate e3sm_to_cmip task from ts #649

Closed
chengzhuzhang opened this issue Dec 6, 2024 · 3 comments · Fixed by #650
Closed

[Enhancement]: Separate e3sm_to_cmip task from ts #649

chengzhuzhang opened this issue Dec 6, 2024 · 3 comments · Fixed by #650
Assignees
Labels
semver: new feature New feature (will increment minor version)

Comments

@chengzhuzhang
Copy link
Collaborator

chengzhuzhang commented Dec 6, 2024

What happened?

@forsyth2 I think we agreed on to make e3sm_to_cmip as a separate task, but not sure if there is an issue for this. Currently, we use a ts_fmt parameter to flag if additional cmip formatted time-series is needed in case of downstream processes, such as ilamb or (ongoing PMP integration).

However, in current implementation, if there is an error from e3sm_to_cmip conversion, any downstream analyses (e3sm_diags, global-time-series) that depends on ts (ncclimo generated time-series files) would not run. It would be cleaner to have the e3sm_to_cmip task a separate task before the PMP integration. Note that, if we need to include e3sm_to_cmip task for MPAS files, we may need a new task because for MPAS output, e3sm_to_cmip depends on native history files at this point.

What machine were you running on?

NA

Environment

NA

What command did you run?

NA

Copy your cfg file

NA

What jobs are failing?

No response

What stack trace are you encountering?

No response

@chengzhuzhang chengzhuzhang added the semver: bug Bug fix (will increment patch version) label Dec 6, 2024
@forsyth2 forsyth2 added semver: new feature New feature (will increment minor version) and removed semver: bug Bug fix (will increment patch version) labels Dec 6, 2024
@forsyth2
Copy link
Collaborator

forsyth2 commented Dec 6, 2024

not sure if there is an issue for this

Yes, this is a duplicate of #467.

@chengzhuzhang
Copy link
Collaborator Author

Thank you, it's from more than one year ago. yeah, we definitely need it to be prioritized.

@forsyth2 forsyth2 mentioned this issue Dec 7, 2024
15 tasks
@forsyth2
Copy link
Collaborator

forsyth2 commented Dec 7, 2024

@chengzhuzhang I'm glad to see this being prioritized. I got started on a preliminary implementation at #650, but it still needs substantial work. Importantly, we're looking at a major version increase (zppy v3.0.0) because the e3sm_to_cmip capabilities will now be implemented via an entirely different section in the cfg files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: new feature New feature (will increment minor version)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants