-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide mapping between EFO response to terms and new OBA replacements #1436
Comments
Here is an UberGraph query
|
As a first step, we should create a 3 column spreadsheet: OBA to EFO to GO mapping. We need a mapping between OBA terms and EFO/GO terms in use so that we can obsolete and replace. For this, we can use [Kalia’s mapping spreadsheet](https://docs.google.com/spreadsheets/d/13qh7dLE38vMyz91oRqj6GzKjFohNazNKAJxKG6Plw1o/edit#gid=0) - but note, the OBA IDs in this are NOT correct. Instead we can use CHEBI IDs. e.g.
Kallia’s spreadsheet has the mapping: EFO:0009167 response to warfarin GO:0042221 CHEBI:10033 From this we can map OBA:2040000 to As a first step, we should create a 3 column spreadsheet: OBA to EFO to GO mapping. |
First draft of EFO/GO --> OBA mapping: |
DEPENDENCY: OBA release needed.
@zoependlington everything with SKOS:exactMatch in this sheet is good, but I think more discussion of transition is needed to ensure that labels match up and the imported terms sit in the right place in the hierarchy. |
I have replaced the obsolete EFO classes with the replacement GO classes in the gsheet tab. |
@dosumis , @zoependlington , |
The aims here has to be to get OBA response_to terms seamlessly integrated into EFO. For this I think we need a mapping sheet for role-based grouping classes as well as the ones here gsheet tab. I think what's needed it:
This would be rather painful to do by hand. @matentzn - I'm wondering if there's a clever way to do this. It would probably take a few attempts to the tables right and review the results. |
Too complicated to answer in a ticket, needs meeting |
2022-08-08:
|
I think it will take a call to fix it - with some prep so that we can see plenty of examples of what. We have the mapping table - but this is a bit confusing to look at on its own. It would be good to have some examples where we can see the representation in OBA and EFO side by side. Also before the call - @rays22 - can we get a status-update on the role-based terms? Are they now in OBA? Is there more work to do on them? I propose that we discuss this on the next OBA call and invite Zoe along. |
Some role-based terms related toresponse_to_chemical_with_role_stimulus have been incorporated into OBA. |
I can't fix this simply with a response on the ticket. We need a call to discuss a general strategy for incorporating OBA terms into EFO where there are existing EFO terms to integrate with that are not in OBA. |
Generate list of all GO classes in the response to branch - this can be done easily with a query of UberGraph.
SPARQL query for xrefs to these terms => EFO terms.
Draft query here - needs some work.
TODO assign to @rays22 (needs to be added to EFO)
The text was updated successfully, but these errors were encountered: