EDDN: Don't blindly replay old messages 'as' the current application version #1431
Closed
3 tasks done
Labels
Milestone
With reference to #1403 it is entirely possible for someone to be playing with "Delay sending until docked", such that they get EDDN messages recorded under one EDMC version and some time later they actually get sent (first attempt) under a later version.
The current
plugins/eddn.py:EDDN.send()
code blindly uses the current application version in the EDDN message'ssoftwareVersion
field.This can thus give the false impression that this 'current' version has a bug that it doesn't, if an older version built a bad message that has been sat in the replaylog.
So:
(sent with <name> <version>)
with respect to what's actually doing the sending. Yes, this might look weird in the EDDN stats, tough. That's only cosmetic, we need to be clear on what happened. We could just append(replaying from older)
to limit the set of new spammier version strings, but I'm not sure it's worth trying to avoid the spam.The text was updated successfully, but these errors were encountered: