Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions logged on startup and shutdown #2301

Open
aussig opened this issue Sep 28, 2024 · 5 comments
Open

Exceptions logged on startup and shutdown #2301

aussig opened this issue Sep 28, 2024 · 5 comments
Assignees
Labels
bug unconfirmed An unconfirmed bug
Milestone

Comments

@aussig
Copy link
Contributor

aussig commented Sep 28, 2024

Please complete the following information:

EDMC Version:

  • 5.12.0+cc6e200

OS Details:

  • Operating System: Windows 10
  • Version: 10.0.22631
  • Machine: AMD64
  • Python Version: 3.11.9

Environment Details

  • Detected Locale: English_United Kingdom
  • Detected Encoding: utf8
  • Journal Directory: .
  • Game Version: ValueError
  • Game Build: ValueError
  • Using Odyssey: ValueError
  • Journal Dir Lockable: True

Describe the bug

On starting up EDMC, am getting the following exception thrown in the EDMC log file:

Exception in thread DDE worker:
Traceback (most recent call last):
  File "threading.pyc", line 1045, in _bootstrap_inner
  File "threading.pyc", line 982, in run
  File "protocol.pyc", line 206, in worker
TypeError: Objects of type 'int' can not be converted to Unicode.

On shutting down EDMC, am getting two different exceptions thrown, both from built-in plugins, in both the main EDMC log and the debug log:

2024-09-28 07:30:41.406 UTC - ERROR - 61296:42352:42352 plug.notify_stop:273: Plugin "EDDN" failed
Traceback (most recent call last):
  File "plug.pyc", line 270, in notify_stop
  File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 2240, in plugin_stop
    this.eddn.close()
  File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 607, in close
    self.sender.close()
  File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 245, in close
    self.db.close()
sqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread. The object was created in thread id 54412 and this is thread id 42352.

and

2024-09-28 07:30:41.408 UTC - ERROR - 61296:42352:42352 plug.notify_stop:273: Plugin "EDSM" failed
Traceback (most recent call last):
  File "plug.pyc", line 270, in notify_stop
  File "C:\Program Files (x86)\EDMarketConnector\plugins\edsm.py", line 264, in plugin_stop
    this.thread.join()  # type: ignore
    ^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'join'

To Reproduce
Steps to reproduce the behavior:

  1. Launch EDMC
  2. Quit EDMC
  3. Examine log files

Expected behavior

No errors on startup or shutdown

Logs

EDMarketConnector-debug.log
EDMarketConnector.log

@aussig aussig added bug unconfirmed An unconfirmed bug labels Sep 28, 2024
@aussig
Copy link
Contributor Author

aussig commented Sep 28, 2024

Interesting information in the system profiler:

  • Operating System: Windows 10
  • Version: 10.0.22631

My actual O/S, from Windows System Profiler is:

  • OS Name: Microsoft Windows 11 Pro
  • Version: 10.0.22631 Build 22631

Also, not too sure what's going on here:

  • Game Version: ValueError
  • Game Build: ValueError
  • Using Odyssey: ValueError

Would you like me to raise a separate issue for that?

@Syzuna
Copy link

Syzuna commented Sep 28, 2024

Win 11 being reported as Win 10 is nothing new.
That is on Microsoft though.

The ValueErrors seem to be intended from what I saw in the code if the profiler can't find a log file to get the info from.
See: https://github.com/EDCD/EDMarketConnector/blob/main/EDMCSystemProfiler.py#L53-L83

@Rixxan Rixxan self-assigned this Sep 29, 2024
@Rixxan Rixxan added this to the 5.13 milestone Sep 29, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Sep 29, 2024
@Rixxan Rixxan moved this from Needs triage to Medium Priority in Bug Triage Sep 29, 2024
@Rixxan
Copy link
Contributor

Rixxan commented Sep 30, 2024

Issue with system profile identified and fix on the way in next release.

@Rixxan
Copy link
Contributor

Rixxan commented Oct 1, 2024

Issue with system profiler has been fixed in the latest beta release. This is on deck for attention right after.

@aussig
Copy link
Contributor Author

aussig commented Oct 4, 2024

I haven't seen any of these exceptions being logged in v5.12.1 since using it over the last day. I can't be certain they are fixed after such a short testing time of course, but suspect that something in the latest release (Pathlib related?) solved the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unconfirmed An unconfirmed bug
Projects
Status: Medium Priority
Development

No branches or pull requests

3 participants