Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations welcome #24

Open
Marginal opened this issue Sep 2, 2015 · 95 comments
Open

Translations welcome #24

Marginal opened this issue Sep 2, 2015 · 95 comments

Comments

@Marginal
Copy link
Contributor

Marginal commented Sep 2, 2015

If you'd like this app translated into your language please comment below and join the project in OneSky.

Note that about half of the phrases are Federal, Empire, Combat, etc ranks. It's probably best to leave these untranslated, or to translate to the supported in-game language that speakers of your language are mostly likely to choose.

@koreldan
Copy link

Italian done

@Marginal
Copy link
Contributor Author

Italian done

Thanks. Added your changes in cafbde8.

Still welcome for more translations - particularly Spanish and Russian.

@Uriei
Copy link

Uriei commented Dec 21, 2015

I could help on the Spanish one, but I don't play on Spanish client because I like to play in English :P

@bubis7
Copy link

bubis7 commented Dec 21, 2015

I can translate to Latvian, and get some of my friends to do it in Russian maybe. ;)

@Marginal
Copy link
Contributor Author

Please do join the OneSky project if you would like to make a translation. There are currently 147 phrases, but about half of those are just the Federation/Empire/Combat/etc ranks.

@bubis7
Copy link

bubis7 commented Dec 21, 2015

Could you add the languages you want to be translated, or is it done by me? I dont see an a option to add Latvian or Russian.

@Marginal
Copy link
Contributor Author

I've added Latvian, Russian and Spanish.
I'll fill in the Russian ranks with info from the Russian Elite wiki.

Do you not see a "Manage Languages" option in the left-hand bar? (Sorry, this is the first time I'm using OneSky).

@bubis7
Copy link

bubis7 commented Dec 21, 2015

No im not seeing them, I assume that`s because i'm not a participant in that project, but then again, i dont see a option to participate in it.

@Marginal
Copy link
Contributor Author

I've just logged in under another account, and I see what you mean.
Anyway I've added Latvian and Russian so you should now be able to click on them and start editing.

@nnemkin
Copy link

nnemkin commented Dec 23, 2015

Hey, I've updated Russian translation, except a few OS X specific strings (no Macs around to check for official translations).

@Marginal
Copy link
Contributor Author

I've updated Russian translation, except a few OS X specific strings (no Macs around to check for "official" translations).

Thanks. Given that on OSX hotkey/shortcuts are described as Сочетание клавиш, can you translate the remaining two?

@nnemkin
Copy link

nnemkin commented Dec 23, 2015

I just did that, should be close enough.

@Marginal
Copy link
Contributor Author

Thanks. Added Russian in 82b1702.

@QNimbus
Copy link

QNimbus commented Dec 24, 2015

Would you like a Dutch (NL/Nederlands) translation? Maybe I can help?

@Marginal
Copy link
Contributor Author

I've added Dutch. Go for it.
Probably best (and easiest) to leave the Federal, Empire, Combat, etc ranks in English.

@QNimbus
Copy link

QNimbus commented Dec 25, 2015

I've completed the Dutch translation - I've left all the ranks alone since there is no official Dutch translation of E:D out. I did, however translate the 3 designations of the ranks since I noticed that the other languages had translations for those as well... (e.g. 'Trade' => 'Handels rang', 'Combat' => 'Gevechts rang').... However, I'm not too sure of these and you might want to change those back to their English counterparts....

Best of luck and thanks for the great app!

Bas - CMDR CoolBreeze

@Marginal
Copy link
Contributor Author

Great, thanks. Will commit after Christmas.

@bubis7
Copy link

bubis7 commented Dec 26, 2015

Just completed Latvian translation and also like QNimbus left rankings untranslated

@Marginal
Copy link
Contributor Author

Thanks. I'll also include Latvian in the next release.

@Marginal
Copy link
Contributor Author

Added Dutch in 4d0ba5e.
Added Latvian in 1fa4ae2.

@Marginal
Copy link
Contributor Author

Marginal commented Jan 2, 2016

Dutch, Latvian and Russian included in Release 2.02.

@CatfoodCZ
Copy link
Contributor

I can do the Czech (CS) translation, if you want.

@Marginal
Copy link
Contributor Author

Great. Have at it.

@CatfoodCZ
Copy link
Contributor

Czech translation is done.

We also met with problem with translation of ranks. At the end we decided, that it doesn't looks good and it can be misleading, so all texts associated with ranks stays in English.

CMDRs CatfoodCZ, Mike Stix, DaraCZ

@Marginal
Copy link
Contributor Author

Thanks. Added Czech in fd86464.

@Marginal
Copy link
Contributor Author

Czech is included in Release 2.06.

@roshavagarga
Copy link

I'm up for doing a Bulgarian translation :)

@Marginal
Copy link
Contributor Author

@roshavagarga Great. Bulgarian added to project.

@Athanasius
Copy link
Contributor

I believe, just for the default flight suit, the Suit part should remain despite the redundancy because it makes more sense.

Suit: Flight Suit makes more sense than Suit: Flight.

The remaining suits are fine, no need to add Suit to the name.

For English we had this debate on Discord. 'Suit Flight Suit' just seems inordinately redundant.

"Flight"
Flight What? -eyes look left- Oh!
"Flight Suit" - got it

It's not like 'Flight' there could mean anything else. It then leaves more room, without (further) widening the UI for the chosen loadout name.

As I won't generally see them I'm willing to be convinced to keep the more verbose forms in other languages :D .

@idontcare1996
Copy link

Yes, leaving the UI less cluttered and with more room takes precedence over that suit redundancy.

For english, french, spanish and german I believe the translations you have there make sense, but I don't think "voador" should be the translation for "Flight" in this context. It should be "de voo", since it's a suit used while flying not a suit that flies (flying suit). Fato (or Traje in PT-BR) voador means Flying Suit in the context of a suit that flies (like those suit with small jet engines).

@leonardofelin
Copy link

Although I agree that "de voo" would fit better (and similar to the Spanish translation), the official translation in-game is "voador". Since the PT-BR translation official forum has been marked as private for some time now, there isn't even a place to complain.

@Athanasius
Copy link
Contributor

Ah, yes, I'm using the actual translations that the game is using for consistency with it. I believe that historically this project has chosen to go with the in-game translation as opposed to a 'more correct' one.

So, even if they are/seem wrong, what I'm proposing to use is still going to be clear enough that an EDMC user will know which suit is being referred to, yes ?

@Athanasius
Copy link
Contributor

Apologies that we didn't upload a week ago when they went into code, but there are now some new phrases to be translated. If they get done within the next 3 hours they'll make it into the next release, 5.1.0, else they'll wait until the next patch release.

@leonardofelin
Copy link

PT-BR translation updated. I can't approve/finalize though (and OneSky hasn't fixed my permissions yet). On the other hand, I'm not sure you even need translations finalized to export them.

@BraINstinct0
Copy link

BraINstinct0 commented Jun 4, 2021

Just a few moments please ;)(ko-KR)

Edit: it's done! Tho, it might have some inaccuracies-hope users will be able to reed itt corectly

@Athanasius
Copy link
Contributor

To be sure it's better known. Yes, we'll back away from trying to translate individual words in phrases, it's just a broken concept: #1074 (comment)

@Athanasius
Copy link
Contributor

Translators, do any of you know there are already instances of phrases where the application uses them in more than one place and it doesn't have a single good translation ?

See #1154

@BraINstinct0
Copy link

I feared that this could be the case, but due to the very low Korean user count(or, at least those who report bugs/mistakes), I couldn't verify this. So it seems... but without any method(or list of those cases) to check it, the only way would be to fix whenever a mistake is reported.

@Athanasius
Copy link
Contributor

I just did a new upload to OneSky. At most there will be three new phrases related to errors sending data to EDDN.

But you should now see much more useful comments on each phrase. These are now auto-generated from in-code comments we add at each use of a translated phrase.

@Athanasius
Copy link
Contributor

But you should now see much more useful comments on each phrase. These are now auto-generated from in-code comments we add at each use of a translated phrase.

And now I've said that I've spotted that some of the script output is in error. Taking the wrong comment into account, i.e.

 51         value={
 52             'auto': _('Auto'),  # LANG: 'Auto' label for Coriolis site overr    ide selection
 53             'normal': _('Normal'),  # LANG: 'Normal' label for Coriolis site     override selection
 54             'beta': _('Beta')  # LANG: 'Beta' label for Coriolis site overri    de selection```

coriolis.py: 'Auto' label for Coriolis site override selection; coriolis.py: 'Normal' label for Coriolis site override selection; coriolis.py: Coriolis normal/beta selection - normal; In files: coriolis.py:53; coriolis.py:99; coriolis.py:115;```

That first "'Auto' label for ..." should be "'Normal label for ...", but it's picking up the comment on the previous line, not the actual code line.

@Athanasius
Copy link
Contributor

OK, that issue should be fixed. New strings uploaded with what should be very good comments for guiding translations.

Now *IS the time to let us know of any concerns you have with the strings. The aim is to address any issues ready for whenever the 5.2.0 release happens.

@Athanasius
Copy link
Contributor

There are some new translations related to the new Privacy options in 5.1.3. I neglected to upload the changed template before the release, but at least now translators can get us caught up in time for the next release.

@Athanasius
Copy link
Contributor

There's a new phrase Inara only accepts Live galaxy data in the update I just uploaded to OneSky.

@BraINstinct0
Copy link

Might've noticed before, but I've practically stopped updating the translations(ko-KR) (due to low user counts and shift of focus to other games/job). Should I report it here?

@Athanasius
Copy link
Contributor

Might've noticed before, but I've practically stopped updating the translations(ko-KR) (due to low user counts and shift of focus to other games/job). Should I report it here?

I had noticed a number of the translations lagging further and further behind. But, as we're assuming the last produced translations are correct and we don't generally re-use any translated string in a different context I don't think it does any harm to continue to include an increasingly less complete translation. To do so seems better than dropping it entirely.

Thanks for your past work!

@Athanasius
Copy link
Contributor

There's some new phrases to be translated with the upload I just made.

NB: Also, this time I decided to choose 'Deprecate' for phrases no longer in the upload. So, shout if you see anything now missing that is actually in our https://github.com/EDCD/EDMarketConnector/tree/develop branch.

@Athanasius
Copy link
Contributor

Also, as no-one has ever actually worked on them, I just removed the Norwegian languages.

@Athanasius
Copy link
Contributor

And a couple more phrases being uploaded/ingested right now....

@C1701D C1701D unpinned this issue Jul 23, 2023
@C1701D C1701D pinned this issue Jul 23, 2023
@Rixxan Rixxan added this to the Documentation milestone Dec 21, 2023
@GLWine
Copy link
Contributor

GLWine commented Jun 17, 2024

Italian translation completed 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests