Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDDN: approachsettlement/1 - Sometimes Latitude is missing #1476

Closed
Athanasius opened this issue Feb 18, 2022 · 2 comments · Fixed by #1477
Closed

EDDN: approachsettlement/1 - Sometimes Latitude is missing #1476

Athanasius opened this issue Feb 18, 2022 · 2 comments · Fixed by #1477
Labels
Milestone

Comments

@Athanasius
Copy link
Contributor

Apparently the Horizons game client might still have a bug where relogging whilst docked at a Planetary Port will sometimes cause an ApproachSettlement event without the Lat/Long co-ordinates.

Certainly the Live EDDN Gateway is now logging things like:

2022-02-17 19:04:34,786 - ERROR - Gateway:274: Failed Validation "[<ValidationError: "'Latitude' is a required property">]" (332, "E:D Market Connector [Windows]", "5.3.0", "https://eddn.edcd.io/schemas/approachsettlement/1", "-")

We should actually check that our outgoing messages have all the required fields.

@Athanasius Athanasius added bug unconfirmed An unconfirmed bug and removed unconfirmed An unconfirmed bug labels Feb 18, 2022
@Athanasius
Copy link
Contributor Author

Arrival (in Horizons):

{ "timestamp":"2022-02-18T14:59:25Z", "event":"ApproachSettlement", "Name":"Mallory Settlement", "MarketID":3537520640, "SystemAddress":1109989017963, "BodyID":64, "BodyName":"Ousey Rock", "Latitude":-72.336609, "Longitude":34.379406 }

After a full game client restart, once more into Horizons:

{ "timestamp":"2022-02-18T15:01:41Z", "event":"ApproachSettlement", "Name":"Mallory Settlement", "MarketID":3537520640, "SystemAddress":1109989017963, "BodyID":64, "BodyName":"Ousey Rock" }

@Athanasius
Copy link
Contributor Author

https://github.com/EDCD/EDMarketConnector/releases/tag/Release%2F5.3.1 has addressed this, auto-updates being enabled Soon[tm].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant