Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export function for Inara build station search adds default modules to the search #756

Open
alex-williams opened this issue May 15, 2024 · 0 comments

Comments

@alex-williams
Copy link
Collaborator

When using the 'stations that sell this build' link to Inara at the top of Coriolis, the link generates a search on Inara that includes modules which are default for the ship, such as default armour, default FSD, default fuel tank, etc. This is inefficient, as in game, stations which sell a ship, may not sell the default modules for the ship... this leads to Inara ignoring stations which sell the ship and the upgraded modules the user actually wants, but doesn't sell the default modules that the user doesn't need to buy anyway. The export link construction needs to be done in such a way, that it checks the build against the ship template for default modules and leaves them out if they are in the build. No one needs to look for a default module, as in the event that someone does actually want to return a ship to stock, at least in the case of core modules, removing the upgrade in any outfitting, in any station, regardless of whether the station sells that default module or not, causes the default module to be purchased and installed on the ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant