Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-party scripts should not run when privacy badger is disabled #2025

Closed
bcyphers opened this issue May 16, 2018 · 4 comments
Closed

First-party scripts should not run when privacy badger is disabled #2025

bcyphers opened this issue May 16, 2018 · 4 comments

Comments

@bcyphers
Copy link
Contributor

Brought up in #2018. The Twitter and Facebook link-unwrapping scripts run even when privacy badger is disabled, and this could make it hard for users to figure out whether PB is breaking something on one of those sites. We should add a check for badger.isPrivacyBadgerEnabled() before running each script.

@bcyphers bcyphers added website The homepage at privacybadger.org and removed website The homepage at privacybadger.org labels May 16, 2018
@ghostwords
Copy link
Member

This is related to #1865. We don't have a cross-browser way of conditionally injecting a before-anything-else-happens content script. We also aren't able to synchronously communicate between content scripts and the background page.

Since messaging seems like the most straightforward way to disable Facebook/Twitter scripts, there will be a (probably sub-second) delay before the scripts will get to do their thing when enabled. This is probably fine for link unwrapping purposes.

@ghostwords
Copy link
Member

See #1859 for the fix for a similar situation.

@Jsnhlbr5
Copy link
Contributor

Jsnhlbr5 commented Sep 7, 2018

I am looking to work this, but would it make sense to wait for #2016 to get merged, since it is making significant changes to at least the Facebook script?

@ghostwords
Copy link
Member

It's fine, I'll handle the merging, whichever way it ends up going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants