Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the pipeline get() method to execute() #108

Open
jesper-friis opened this issue Apr 26, 2023 · 2 comments
Open

Rename the pipeline get() method to execute() #108

jesper-friis opened this issue Apr 26, 2023 · 2 comments

Comments

@jesper-friis
Copy link
Contributor

The name of the pipeline get() method creates confusion for two reasons:

  • it only activates the pipeline execution, but does not return anything (which the name get kind of indicates)
  • it is just too easy to confuse the get() method of the pipeline with the get() methods of the strategies.

Suggestion: rename the get() method of the pipeline to execute().

@CasperWA
Copy link
Contributor

I'm not against this at all. It sounds like a great improvement. I'd like the input of @quaat though.

@daniel-sintef
Copy link
Contributor

daniel-sintef commented Oct 30, 2023

I'd rather not: as someone who recently learned otelib, this did not impact me in any way. I think there is a massive cost introducing these backwards-incompatible changes, and the benefit to me seems purely hypothetical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants