Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how python backend returns values #73

Open
daniel-sintef opened this issue Oct 14, 2022 · 1 comment
Open

Improve how python backend returns values #73

daniel-sintef opened this issue Oct 14, 2022 · 1 comment
Assignees

Comments

@daniel-sintef
Copy link
Contributor

Currently cast the AttributeDict.json() return values in the python backend to bytes manually to make it match the services backend exactly. E.g.,

otelib/backends/python/base.py: return bytes(AttrDict(**session_update).json(), encoding="utf-8")

However, this can probably be improved. Possibly by adding a new bytes return option to AttrDict.

@CasperWA
Copy link
Contributor

I think the solution mentioned in #86 makes the most sense. I have also implemented a solution for this in #134. @daniel-sintef feel free to close this issue if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants