Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get() return entire session instead of SessionUpdate of the last filter #85

Open
jesper-friis opened this issue Nov 19, 2022 · 1 comment

Comments

@jesper-friis
Copy link
Contributor

Assume that you have the following pipeline

pipe = resource >> mapping

Now, when you are calling pipe.get() you will get the SessionUpdate from mapping. However, you would normally be interested in the content (e.g. collection_id) placed in the session by resource. But that is not available from pipe.

Hence, update otelib such that the fetch() method returns the entire session rather than the updates by the last filter.

@CasperWA
Copy link
Contributor

This needs to be addressed and discussed in more detail. What is the expected return content from pipeline.get()? What is the expected way of using OTELib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants