Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix utils.parse_object() #45

Closed
jesper-friis opened this issue Dec 1, 2022 · 0 comments · Fixed by #46
Closed

Fix utils.parse_object() #45

jesper-friis opened this issue Dec 1, 2022 · 0 comments · Fixed by #46
Assignees
@jesper-friis

Comments

@jesper-friis
Copy link
Contributor

jesper-friis commented Dec 1, 2022 •
edited
Loading

utils.parse_object() fails for some special cases as noted in the comment at the bottom of tests/test_utils.py. Fix parse_object() such that it also works for these cases.

Also, as noted in the review of PR #44: clean up code, use regexp for parse_object. Try to avoid redefining built-ins.
@jesper-friis jesper-friis mentioned this issue Dec 3, 2022
Merged
@jesper-friis jesper-friis linked a pull request Dec 3, 2022 that will close this issue
Fix utils.parse_object() #46
Merged
@jesper-friis jesper-friis self-assigned this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesper-friis jesper-friis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix utils.parse_object() EMMC-ASBL/tripper
1 participant
@jesper-friis