-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display any pictures #65
Comments
All the links on example note and it's comments are accessible, What is wrong with the current regex? Any existing issues with it should be linked here. |
I believe the idea is to have URLs pointing to images be not merely rendered as a link, but to display (a thumbnail of) the image itself, when displaying the note. |
Interesting tool (bookmarked), but sub-optimal regex. Instead:
If you compare, using the same tool, you'll notice that the execution time is considerably less (and it'll use less memory, too). This pattern could be refined further, in a bunch of ways, to be more specific (to well-formed URLs). Somewhat moot, now, due to my PR. Reference site: Regular Expressions. |
|
Add a regex like this one to linkily.js ?
(http(s)?://)?(www.)?.*.(jpg|jpeg|png)
Example: note 2439467
The text was updated successfully, but these errors were encountered: