Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viresclient requires markupsafe==2.0.1 #75

Closed
mfbenitezp opened this issue Feb 18, 2022 · 3 comments
Closed

Viresclient requires markupsafe==2.0.1 #75

mfbenitezp opened this issue Feb 18, 2022 · 3 comments

Comments

@mfbenitezp
Copy link

In a recent implementation of VirES using poetry and miniconda, there was an issue that requires downgrading markupsafe to 2.0.1 once I did this, it fixes the issue on my side.

@smithara
Copy link
Member

Thank you for the report

I'm not familiar with poetry (and what issues you might have mixing that with conda) - but can you try replacing the viresclient specified with a dev branch on github. Using pip this is done with:

pip install git+https://github.com/ESA-VirES/VirES-Python-Client@allow-jinja2v3

I guess it is something similar with poetry. That should let it install without complaint with higher versions of markupsafe (actually, with the direct dependency of Jinja2). I think the functionality of viresclient should still work unaffected - let me know if not!

@smithara
Copy link
Member

@mfbenitezp I released a new version (0.10.1) with which you should be able to remove the pin of markupsafe. The problem was that viresclient 0.10.0 was holding back the upgrade of jinja2, which itself was required in order to fix compatibility with a newer version of markupsafe. (pallets/markupsafe#286)

@mfbenitezp
Copy link
Author

Hi @smithara Thanks you for your quick response and release. I also had some issues with jinja in particular when I try to include other spatial packages like geopandas into the python env. I though the issue was with GDAL, but I will check the new release and let you know if now viresclient works well in both conda and poetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants