Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-year test with mid-year restart #2078

Open
samsrabin opened this issue Jul 27, 2023 · 1 comment
Open

Add multi-year test with mid-year restart #2078

samsrabin opened this issue Jul 27, 2023 · 1 comment
Assignees
Labels
testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

I added a bunch of per-harvest and annual output variables as part of #1863, and @billsacks suggested:

We should add one or more tests that exercise the new options and output variables. I think it would be good to have a multi-year test with a mid-year restart to ensure that all of the necessary variables are being saved to the restart file.

Maybe something like ERS_Lm54.f10_f10_mg37.IHistClm51BgcCrop.cheyenne_intel.clm-cropMonthOutput?

@samsrabin samsrabin added testing additions or changes to tests next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 27, 2023
@billsacks
Copy link
Member

Thanks for pursuing this, @samsrabin . I think you have the best sense of what the most appropriate test would be, including the necessary length, but this seems like it's probably good. A couple of comments, though:

  • Using a Hist compset makes sense if transient capability is important to test with this; otherwise, if the focus is just on making sure that a mid-year restart works for some of this crop logic, a present day (I2000) compset could be better since there will be more crop areas present in that one than in an IHist test.
  • For a test of this length, we should explicitly specify a PE layout, like ERS_Lm54_P144x1, so that we use more than the default number of processors for this resolution, which will give us faster turnaround.

@samsrabin samsrabin self-assigned this Jul 27, 2023
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing additions or changes to tests
Development

No branches or pull requests

2 participants