Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to flip between different dust emission parameterizations #2150

Closed
ekluzek opened this issue Sep 10, 2023 · 1 comment · Fixed by #2545
Closed

Add capability to flip between different dust emission parameterizations #2150

ekluzek opened this issue Sep 10, 2023 · 1 comment · Fixed by #2545
Assignees
Labels
blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 10, 2023

I introduce this idea here:

#1604 (comment)

I think it would be worthwhile to add the capability to flip between different dust emission parameterizations, for the reasons stated above. This would be done after #1836 is complete. And before #1897 comes in.

This would be done similarly as other OO options we have for code options is done. So a Factory that reads in a namelist to determine which one, and instantiate it. And then an abstract base class, and then specific versions based off the base class.
This doesn't actually add that much code. The abstract class and factory for Fire for example is only about 400 lines. With most of that being boilerplate. So I think adding this would not be a big development.

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability type: -discussion blocked: dependency Wait to work on this until dependency is resolved labels Sep 10, 2023
@ekluzek ekluzek self-assigned this Sep 10, 2023
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 10, 2023

So tasks for it are:

Create a branch and PR for this work 3
Develop the FORTRAN code for this 8-24
Run testing, respond to issues 2-4
Merge to latest 1
Run testing respond to issues 1-3
Make the tag 1

Min: 16
Avg: 36
Max: 40
Estimate average of above: 30

@ekluzek ekluzek changed the title Add capability to flip between different dust emission parameterizations? Add capability to flip between different dust emission parameterizations Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant