Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUMBER2 refactoring inputdata adjustments #2410

Open
4 tasks done
TeaganKing opened this issue Mar 8, 2024 · 9 comments
Open
4 tasks done

PLUMBER2 refactoring inputdata adjustments #2410

TeaganKing opened this issue Mar 8, 2024 · 9 comments
Assignees
Labels
code health improving internal code structure to make easier to maintain (sustainability)

Comments

@TeaganKing
Copy link
Contributor

TeaganKing commented Mar 8, 2024

@slevis-lmwg slevis-lmwg added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Mar 11, 2024
@samsrabin
Copy link
Collaborator

These issues are introduced by #2155 but are okay to be resolved after that comes in.

@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) and removed next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Mar 14, 2024
@slevis-lmwg
Copy link
Contributor

I'm happy to help with the move of data to /inputdata and subsequent ./rimport.

First I would like to have a quick discussion of what exactly (datm, lai_streams, fsurdat files?) needs to move where exactly. Under /inputdata I see:

  • /atm/datm7/CLM1PT_data
  • /lnd/clm2/lai_streams
  • for fsurdat we already have a clear setup under /lnd/clm2/surfdata_esmf

@wwieder
Copy link
Contributor

wwieder commented Apr 1, 2024

This is nearly addressed in #2155. The there are a few outstanding TODO items in plumber2_usermods.py that we can discuss. These include:

  • updating usermods to point to the 5.2 surface data @slevis-lmwg already created
  • adding PLUMBER2SITE to cdeps.

Should these be added to the list in the first comment of the issue?

@TeaganKing
Copy link
Contributor Author

I wanted to follow up on the to do items in this ticket.

  • I'm not sure of the rimport status. @slevis-lmwg do you know the status of this? I think we may need to loop in Will or Erik if those questions from above are still unclear.
  • Updating usermods is being done in Plumber.5.2 #2485
  • Adding PLUMBER2SITE to CDEPS is being done in CDEPS PR #262.

@slevis-lmwg
Copy link
Contributor

Regarding rimport, we never followed up regarding my question above. Before I execute the command, I would like confirmation that these are the correct directories that need rimporting:

/glade/campaign/cesm/cesmdata/inputdata/atm/datm7/CLM1PT_data/PLUMBER2
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/lai_streams/PLUMBER2
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/PLUMBER2

A "thumbs up" to this post will do, and I will go ahead with the rimport.

@TeaganKing
Copy link
Contributor Author

Ok thanks Sam. I'm not totally sure, so I'm going to tag @wwieder about this one...

@TeaganKing
Copy link
Contributor Author

Hi @slevis-lmwg , I was just chatting with @wwieder and we'll want to use the following directories for the rimport.
$DIN_LOC_ROOT/atm/datm7/CLM1PT_data/PLUMBER2
$DIN_LOC_ROOT/lnd/clm2/lai_streams/PLUMBER2
$DIN_LOC_ROOT/lnd/clm2/surfdata_esmf/PLUMBER2

@slevis-lmwg
Copy link
Contributor

@TeaganKing thank you for bringing this up in today's meeting. I ran ./rimport just now to get all the files from these three directories onto the repository. This is done in /glade/campaign/cesm/cesmdata/inputdata:

./rimport -list plumber_datm.list
./rimport -list plumber_lai_streams.list
./rimport -list plumber_fsurdat.list

@TeaganKing
Copy link
Contributor Author

Fantastic, thanks so much @slevis-lmwg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Development

No branches or pull requests

5 participants