Excess ice testing: cold-start both on and off, and finidat (without excess ice) and streams on

[ekluzek]

When excess ice is turned on by default for clm6_0 the main use of excess ice streams will be for cold-start cases. Hence, it makes sense to me that the ExcessceStreams test mod should be changed to also do a cold-start. Since, it'll appear as a new test, this could be done on the b4b-dev branch.

As @mvdebolskiy points out below the thing missing is an excess ice test with streams on and an finidat file without excess ice on it.

We'll wait on this until excess ice is turned on by default in clm6_0, because that will add more testing for excess ice. So this is blocked by #2466.

Definition of done:

• Excess ice turned on by default for clm6_0
• Make sure there are tests with and without excess ice from a coldstart
• Add a test with a finidat file without excess ice and streams on

[ekluzek]

In terms of evaluating the excess ice tests. Right now we only have two excess ice tests in the aux_clm test list and one for ctsm_sci. However, when excess ice is turned on for clm6_0, more tests will be exercising excess ice and so the three tests that are specific for excess ice might be sufficient, with all of the clm6_0 tests also exercising excess ice.

[ekluzek]

@mvdebolskiy thoughts on this?

[mvdebolskiy]

It will get tested automatically when it is default on any ColdStart tests. I would rather add 2 tests where it is turned off on the cold start (for temperature testing) and one with finidat with no excess ice vars and streams turned on (since we want to keep this possibility).

[ekluzek]

Good point @mvdebolskiy I changed the title and added to the text at the top to lay out a plan for doing what you suggest. Feel free to add more feedback...