Try to improve numerical precision of dynbal water and energy adjustments #570
Labels
closed: wontfix
We won't fix this issue, because it would be too difficult and/or isn't important enough to fix
enhancement
new capability or improved behavior of existing capability
This is motivated by seeing some relatively large changes in the dynbal water and energy adjustments (
QFLX_LIQ_DYNBAL
andEFLX_DYNBAL
) that I'm pretty sure are arising just from changing wa_col from 5000 to 4000 (a possibly-unintentional change in #523 ).Currently, the dynbal water and energy adjustments operate by summing total water and energy before and after the changes in area. However, this means that changes in relatively small pools have their numerical precision compromised by potentially-unchanging, large pools. One such large pool is wa_col, but this problem probably occurs to a lesser extent when we have changes in canopy water with no changes in the much larger soil water states.
One way we could deal with this problem is to take differences of each state variable separately, then add those differences. Thus, for example, if wa_col isn't changing, then its difference would be 0, rather than swamping the differences in the terms that are changing.
If we do more rigorous water and energy conservation with dynamic landunits, as suggested by #274 , then this may become irrelevant, or at least less important.
The text was updated successfully, but these errors were encountered: