Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-precision history output does NOT work (rtmhist_ndens) #18

Open
ekluzek opened this issue Oct 18, 2018 · 2 comments
Open

Single-precision history output does NOT work (rtmhist_ndens) #18

ekluzek opened this issue Oct 18, 2018 · 2 comments
Assignees

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Oct 18, 2018

The single-precision output namelist option is NOT functional. Output is always double precision even when rtmhist_ndens==2. This problem goes back to the code inception because this option wasn't implemented.

@ekluzek ekluzek added the bug label Oct 18, 2018
@ekluzek ekluzek self-assigned this Oct 18, 2018
@ekluzek
Copy link
Contributor Author

ekluzek commented Oct 18, 2018

A fix for this came in with release-cesm2.0.01. It converts to single-precision when history output is being written.

@ekluzek ekluzek closed this as completed Oct 18, 2018
@ekluzek
Copy link
Contributor Author

ekluzek commented Oct 18, 2018

Reopening this issue as the fix isn't extensive enough. We've seen cases where numeric conversion issues kill simulations when there is some problem with the data values (when history is written). Also since you only detect the issue when history is written rather than by internal conversion to the history buffers, you don't detect issues right away. Thus we plan to fix this with single-precision history buffers, similarly on how it's done in CTSM.

@ekluzek ekluzek reopened this Oct 18, 2018
@ekluzek ekluzek changed the title Single-precision history output does NOT work Single-precision history output does NOT work (rtmhist_ndens) Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant