Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework #2828 to avoid changing answers for E3SM #2898

Closed
billsacks opened this issue Nov 1, 2018 · 8 comments
Closed

Rework #2828 to avoid changing answers for E3SM #2898

billsacks opened this issue Nov 1, 2018 · 8 comments

Comments

@billsacks
Copy link
Member

#2828 updated datm in a way that likely affected e3sm as well as cesm, but these changes aren't actually wanted in e3sm (yet). @ekluzek will rework this to distinguish between cesm and e3sm.

Initial questions before @ekluzek tackles this:

(1) @jgfouca can you let us know once you have confirmed that that PR was indeed responsible for some of the unexpected diffs you were seeing?

(2) @rljacob and/or @jgfouca - do you want Erik to fix this on maint-5.6 or just the master branch?

@jedwards4b
Copy link
Contributor

I'm pretty sure that they are only working with master and not maint-5.6

@rljacob
Copy link
Member

rljacob commented Nov 1, 2018

Just master.

@jgfouca
Copy link
Contributor

jgfouca commented Nov 7, 2018

@billsacks , confirmed. The change to namelist_definition_datm.xml causes the DIFF.

@billsacks
Copy link
Member Author

Thanks, @jgfouca . So, @ekluzek can you please make this change on master when you get a chance in your schedule?

@ekluzek
Copy link
Contributor

ekluzek commented Nov 7, 2018

OK

@jgfouca
Copy link
Contributor

jgfouca commented Nov 12, 2018

@ekluzek , I had to fix this on E3SM in order to get things to work without DIFFing. You can see the fix here: E3SM-Project/E3SM@11099cf

If you are OK with this fix, you don't need to do anything. It will come into ESMCI/CIME with the next E3SM split.

@ekluzek
Copy link
Contributor

ekluzek commented Nov 12, 2018

OK, I took a look and it looks correct to me. I made one comment that you can take or reject.

@rljacob
Copy link
Member

rljacob commented May 15, 2019

telecon: fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants