Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename csm_share ? #3953

Open
rljacob opened this issue May 4, 2021 · 10 comments
Open

rename csm_share ? #3953

rljacob opened this issue May 4, 2021 · 10 comments

Comments

@rljacob
Copy link
Member

rljacob commented May 4, 2021

Does the "csm" in "csm_share" stand for Climate System Model? That's pretty generic now. Or should we rename it to "cime_share". Is renaming something that has to be done in CCS or can we each rename it on our own after getting our own copies?

@billsacks
Copy link
Member

@fischer-ncar can you comment here? I think you have renamed it in your cime split work, right?

@ekluzek
Copy link
Contributor

ekluzek commented May 4, 2021

Historically it was named that when it was created to refer to the original version of the Climate System Model (CSM). Meaning code shared between CESM model components. So yes if you think of CSM now meaning Climate System Model in a more generic sense -- you don't have to rename it. cime_share is probably a better name for now. But, it's always a question of how important is to change these directory names.

@rljacob
Copy link
Member Author

rljacob commented May 4, 2021

The current directory names under src/share are fine. Its just the name of the resulting library that is really old.

@rljacob
Copy link
Member Author

rljacob commented May 6, 2021

To partly answer my question: CIME CCS assumes there's a library called "csm_share" in Tools/Makefile and build.py. So I think we should coordinate if we want to rename it.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 10, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
@rljacob rljacob removed the Stale label May 15, 2023
@rljacob rljacob reopened this May 15, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 15, 2023
@mvertens
Copy link
Contributor

I agree that this should be changed and not closed.

@rljacob rljacob removed the Stale label Jun 15, 2023
@rljacob
Copy link
Member Author

rljacob commented Jun 15, 2023

@ekluzek what's the label to keep it from being auto-closed?

@jedwards4b
Copy link
Contributor

Low Priority - now set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants