Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different argument order for library vs. component buildlibs #4034

Open
billsacks opened this issue Jul 10, 2021 · 3 comments
Open

Different argument order for library vs. component buildlibs #4034

billsacks opened this issue Jul 10, 2021 · 3 comments

Comments

@billsacks
Copy link
Member

This isn't exactly a bug itself, but can contribute to bugs, including one that stumped @jedwards4b and me for a while this week: The order of the command-line arguments to the buildlib script, when called as a subprocess, differs for libraries

run_sub_or_cmd(my_file, [full_lib_path, os.path.join(exeroot, sharedpath), caseroot], 'buildlib',
[full_lib_path, os.path.join(exeroot, sharedpath), case], logfile=file_build)

vs components

compile_cmd = "MODEL={compclass} COMP_CLASS={compclass} COMP_NAME={compname} {cmd} {caseroot} {libroot} {bldroot} ".\
format(compclass=compclass, compname=compname, cmd=cmd, caseroot=caseroot, libroot=libroot, bldroot=bldroot)

One implication of this is that the parse_input command in buildlib.py cannot be used for libraries.

Changing the argument order for components would be a pain (requiring coordinated changes in a bunch of repositories). But I wonder if it would be feasible to change the argument order for libraries to match that of components?

Even better would be changing these positional arguments to named arguments – for both libraries and components – but I can't think of a backwards compatible way to do that (so again, it would require coordinated updates in a bunch of repositories).

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 7, 2023
@jgfouca jgfouca removed the Stale label May 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 7, 2023
@jasonb5 jasonb5 removed the Stale label Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants