Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employer_Role_IG_firm/model.xml is not valid XML #11

Open
Allzi opened this issue Jan 25, 2020 · 3 comments
Open

Employer_Role_IG_firm/model.xml is not valid XML #11

Allzi opened this issue Jan 25, 2020 · 3 comments
Assignees

Comments

@Allzi
Copy link

Allzi commented Jan 25, 2020

File eurace_unibi/Labour/Employer_Role_IG_firm/model.xml is not valid xml.

  • opening tag for 'agents' is missing
  • lines 599-604 are rubbish
  • 'messages' element present in other model files is replaced with 'message' element
@Allzi Allzi changed the title Employer_Role_IG_firm/model.xml not valid XML Employer_Role_IG_firm/model.xml is not valid XML Jan 25, 2020
@Allzi
Copy link
Author

Allzi commented Jan 25, 2020

Also closing tag for 'agents' is missing in Statistical_Office_IGFirm_real.xml
All other xml-files parse just fine.

@svdhoog
Copy link
Contributor

svdhoog commented Jan 25, 2020

Thanks for the checks! The Employer_Role_IG_firm is deprecated code and switched off in the main xml file, eurace_model.xml. It has actually been abandoned code for a few years, at least since 2014.
In all applications of the Eurace@Unibi model, we have no employees in the investment goods firm (IGFirm).

Note that in eurace_model.xml we have a dummy model active:

  <model>
   <file>Labour/Employer_Role_IG_Firm_dummy/model.xml</file>
   <enabled>true</enabled>
  </model>

@svdhoog svdhoog self-assigned this Jan 25, 2020
@Allzi
Copy link
Author

Allzi commented Jan 26, 2020

Fair enough. I was a bit surprised about the broken xml when parsing that to more readable format.
RIP that part of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants