refactor: rename charging profile callback variables for clarity Signed-off-by: thenaserov naser.rezayi.nr@gmail.com #981
Conversation
thenaserov
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
|
Thanks for the PR, this is just a formality, but could you add a sign-off line to your commit as stated in the failing CI step "DCO"? https://github.com/EVerest/libocpp/pull/981/checks?check_run_id=36899394931 |
thenaserov
changed the title
|
Hello and thank you for your consideration!
Is this one correct?
"refactor: rename charging profile callback variables for clarity
Signed-off-by: thenaserov ***@***.***"
I just edited my commit!
…On Mon, Feb 10, 2025, 23:35 Kai Hermann ***@***.***> wrote:
Thanks for the PR, this is just a formality, but could you add a sign-off
line to your commit as stated in the failing CI step "DCO"?
https://github.com/EVerest/libocpp/pull/981/checks?check_run_id=36899394931
Otherwise we won't be able to merge this even after an approval 😢
—
Reply to this email directly, view it on GitHub
<#981 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANBMEBAW5Y6HCUBUPE3SCJT2PEBCHAVCNFSM6AAAAABWX45VOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZGEYTMNZZGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Almost 🙂 there's a how-to in the link I commented, you basically add this sign-off line to your commit and force-push to this branch again, I quote:
|
…ed-off-by: Naser Rezaei naser.rezayi.nr@gmail.com - Renamed and to to better reflect their purpose. - Updated all related comments in Doxygen and code to align with the new naming convention. - The new name clarifies that the callback is triggered whenever charging profiles are updated, not just when they are set. Signed-off-by: thenaserov <naser.rezayi.nr@gmail.com>
thenaserov
force-pushed
the
charging_profile_callbacks_update
branch
from
d47c378 to
f361b1f
Compare
|
Dear Kai
I just followed and took actions for the mentioned issue you helped me with!
Thanks a million! I did the push.
So happy to have my very first contribution (very small one).
Regards
…On Mon, Feb 10, 2025 at 11:51 PM Kai Hermann ***@***.***> wrote:
Hello and thank you for your consideration! Is this one correct?
Almost 🙂 there's a how-to in the link I commented, you basically add this
sign-off line to your commit and force-push to this branch again, I quote:
To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull
request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push
--force-with-lease origin charging_profile_callbacks_update
—
Reply to this email directly, view it on GitHub
<#981 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANBMEBHI3A22TLISRYYXMED2PEC3NAVCNFSM6AAAAABWX45VOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZGE2DOMZXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks! I've just triggered the build & test ci pipeline and it looks like there are still some build errors. Can you have a look at those? |
Updated all related comments in Doxygen and code to align with the new naming convention.
The new name clarifies that the callback is triggered whenever charging profiles are updated, not just when they are set.
[*] I have performed a self-review of my code
[*] I have made corresponding changes to the documentation
[*] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
[*] I read the contribution documentation