Move firmware update to new functional block #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
maaikez
force-pushed
the
feature/move-availability-callbacks-and-handlers-to-new-functional-block
branch
from
bce747f to
98360d6
Compare
Base automatically changed from
feature/move-availability-callbacks-and-handlers-to-new-functional-block
to
main
January 24, 2025 13:33
maaikez
force-pushed
the
feature/move-firmware-update-to-new-functional-block
branch
from
283d4b8 to
be09ba7
Compare
maaikez
force-pushed
the
feature/move-firmware-update-to-new-functional-block
branch
from
be09ba7 to
4d3736a
Compare
Pietfried
requested changes
Jan 30, 2025
Comment on lines
6
to
8
| #include <ocpp/v201/message_handler.hpp> | ||
|
|
||
| #include <ocpp/common/message_dispatcher.hpp> | ||
|
|
||
| #include <ocpp/v201/messages/UpdateFirmware.hpp> |
There was a problem hiding this comment.
Suggested change
| #include <ocpp/v201/message_handler.hpp> | |
| #include <ocpp/common/message_dispatcher.hpp> | |
| #include <ocpp/v201/messages/UpdateFirmware.hpp> | |
| #include <ocpp/common/message_dispatcher.hpp> | |
| #include <ocpp/v201/message_handler.hpp> | |
| #include <ocpp/v201/messages/UpdateFirmware.hpp> |
| this->device_model.get_value<std::string>(ControllerComponentVariables::FirmwareVersion)); | ||
| this->security.security_event_notification_req(CiString<50>(ocpp::security_events::FIRMWARE_UPDATED), | ||
| std::optional<CiString<255>>(firmwareVersionMessage), true, | ||
| true); // L01.FR.31 |
There was a problem hiding this comment.
I think we need to call this->restore_all_connector_states(); here as well, otherwise evses may stay in unavailable after a successful install. Could you please double check?
There was a problem hiding this comment.
Well it was not there, so I am not sure if it should be there. But it seems logical to me.
Asked @RobertDeLeeuw about it, as he added the call to this function.
There was a problem hiding this comment.
Talked with @hikinggrass that we probably just want this to be called when a firmware update end state is reached. Added code for that.
maaikez
force-pushed
the
feature/move-firmware-update-to-new-functional-block
branch
2 times, most recently
from
07f505d to
feb8b18
Compare
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…ity and security. Make it compile. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/move-firmware-update-to-new-functional-block
branch
from
feb8b18 to
ad072e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move firmware update functions to a functional block
Issue ticket number and link
#951
Checklist before requesting a review