-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nan threshold for conservative regridding (continuation of #39) #41
Conversation
@slevang I tidied up some things and added additional documentation to your PR. Could you have a (quick) look at this? If not just let me know and I merge it as-is |
Thanks, and good timing! I finally have some free time this week and was planning to finish this up. I did want to revisit the way I implemented the NaN thresholding across dimensions following this comment, and maybe try being more explicit by having the user pass a mask. |
Great! Maybe it's better to merge this PR first, so you can work in a clean branch. That would be easier to review. I did move those comments to #42 already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for me, thanks for finishing up the typing, etc. I can work on any small follow ups in another PR. This already has quite a lot of changes.
Continuation of #39