Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nan threshold for conservative regridding (continuation of #39) #41

Merged
merged 18 commits into from
Sep 4, 2024

Conversation

BSchilperoort
Copy link
Contributor

@BSchilperoort BSchilperoort commented Sep 2, 2024

Continuation of #39

@BSchilperoort BSchilperoort linked an issue Sep 3, 2024 that may be closed by this pull request
@BSchilperoort
Copy link
Contributor Author

@slevang I tidied up some things and added additional documentation to your PR. Could you have a (quick) look at this? If not just let me know and I merge it as-is

@slevang
Copy link
Collaborator

slevang commented Sep 3, 2024

Thanks, and good timing! I finally have some free time this week and was planning to finish this up.

I did want to revisit the way I implemented the NaN thresholding across dimensions following this comment, and maybe try being more explicit by having the user pass a mask.

@BSchilperoort
Copy link
Contributor Author

BSchilperoort commented Sep 3, 2024

Thanks, and good timing! I finally have some free time this week and was planning to finish this up.

I did want to revisit the way I implemented the NaN thresholding across dimensions following this comment, and maybe try being more explicit by having the user pass a mask.

Great! Maybe it's better to merge this PR first, so you can work in a clean branch. That would be easier to review.

I did move those comments to #42 already

Copy link
Collaborator

@slevang slevang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, thanks for finishing up the typing, etc. I can work on any small follow ups in another PR. This already has quite a lot of changes.

@BSchilperoort BSchilperoort merged commit 524c1c8 into main Sep 4, 2024
8 checks passed
@BSchilperoort BSchilperoort deleted the nan-threshold-bart branch September 4, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants