Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(152): Adjust Sidebar Item Widths to match Figma Design #159

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(152): Adjust Sidebar Item Widths to match Figma Design #159

merged 2 commits into from
Dec 16, 2024

Conversation

SoulKa
Copy link
Collaborator

@SoulKa SoulKa commented Dec 13, 2024 •
edited
Loading

Changes

  • Using flex for sidebar layout
  • Fix width of lower divider in sidebar
  • Fix width of sidebar elements (see hovered item) to match Figma design

Testing

image

Checklist

  • Issue has been linked to this PR
  • Code has been reviewed by person creating the PR
  • Commit messages, branch names, code formatting adheres to our Contributing Guidelines
  • Automated tests have been written, if possible
  • Manual testing has been performed
  • Documentation has been updated, if necessary
  • Changes have been reviewed by second person

@SoulKa SoulKa linked an issue Dec 13, 2024 that may be closed by this pull request
Sidebar Selection highlight is not full Width #152
Closed
@SoulKa SoulKa self-assigned this Dec 13, 2024
@SoulKa SoulKa added bug frontend Frontend related task labels Dec 13, 2024
@SoulKa SoulKa added this to the v0.1 milestone Dec 13, 2024
@SoulKa SoulKa force-pushed the fix/152-sidebar-width branch from 8abe3d2 to 3655c36 Compare December 13, 2024 09:20
@SoulKa SoulKa force-pushed the fix/152-sidebar-width branch from 3655c36 to e4d80bb Compare December 13, 2024 09:21
@giemic8 giemic8 self-requested a review December 13, 2024 20:00
@SoulKa SoulKa merged commit 46d5e1a into main Dec 16, 2024
2 checks passed
@SoulKa SoulKa deleted the fix/152-sidebar-width branch December 16, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giemic8 giemic8 giemic8 approved these changes

Assignees

@SoulKa SoulKa

Labels
frontend Frontend related task
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

Sidebar Selection highlight is not full Width
2 participants
@SoulKa @giemic8