Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: start_jupyter changes are needed #30

Closed
asreimer opened this issue Jun 8, 2019 · 1 comment
Closed

[ENH]: start_jupyter changes are needed #30

asreimer opened this issue Jun 8, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@asreimer
Copy link
Contributor

asreimer commented Jun 8, 2019

Now that the create_bucket workflow has changed and users will not be tasked with choosing the ports to forward into the docker container, we need to change the start_jupyter command.

start_jupyter should check to see if there is already a jupyter lab running in the container and if so, tell the user and/or open a browser tab again.

Additionally, start_jupyter should not take ports numbers as arguments anymore.

These changes need to be done at the resencmd.py level of the code.
@asreimer asreimer added the enhancement New feature or request label Jun 8, 2019
@asreimer
Copy link
Contributor Author

Done in #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asreimer