Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide possibility for user-defined gapfilling function used after uStar filtering #62

Open
bgctw opened this issue Apr 14, 2023 · 1 comment

Comments

@bgctw
Copy link
Member

bgctw commented Apr 14, 2023

Currently sMDSGapFillAfterUstar calls .self$sMDSGapFill. If a user wants to modify the gapfilling, e.g. by including more environmental variables, then he has to recode the entire uStar-Filtering/Distribution procedure.

Implement an argument fGapFill so that the user can provide its own modified gapfilling function to sMDSGapFillAfterUstar.

@bgctw
Copy link
Member Author

bgctw commented Apr 15, 2023

We are in an object-oriented setting, which already provides the tools to achieve this. Instead of calling a different function than .self$sMDSGapFill in sMDSGapFillAfterUstar, just create a drived class, wehre you override the sMDSGapFill method to your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant