-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smalls defects with actions management #222
Comments
I can't reproduce this error.
easy_admin:
entities:
MyEntity:
edit:
actions: [{ name: 'delete', icon: 'minus-circle' }]
easy_admin:
entities:
MyEntity:
form:
actions: [{ name: 'delete', icon: 'minus-square' }]
easy_admin:
entities:
MyEntity:
form:
actions: [{ name: 'delete', icon: 'minus-square' }]
edit:
actions: [{ name: 'delete', icon: 'minus-circle' }] |
I was in a hurry and I write it down wrong: there is no need to use both keys ( I just checked again and both problems are completely reproducible; I can push a branch if you need it. Also, I just saw that it happens too in the It looks like it doesn't use the default FA icon when you specify the action but not the icon. |
@aruku thanks for the explanation. I now fully understand the problem and I can confirm it as a bug. I'm working to fix it. |
This issue has been fixed in #230 |
While doing the same changes as in #221, I also found these 2 small defects.
If I explicitly set the
delete
action in the config for bothedit
andform
keys, the actual button in the interface doesn't show the FA icon because it lacks thei
element inside.And also if I set the same action for both
new
andform
keys, the delete button appears in thenew
view, which doesn't make sense.The text was updated successfully, but these errors were encountered: