Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smalls defects with actions management #222

Closed
aruku opened this issue Apr 14, 2015 · 4 comments
Closed

Smalls defects with actions management #222

aruku opened this issue Apr 14, 2015 · 4 comments
Labels

Comments

@aruku
Copy link

aruku commented Apr 14, 2015

While doing the same changes as in #221, I also found these 2 small defects.

If I explicitly set the delete action in the config for both edit and form keys, the actual button in the interface doesn't show the FA icon because it lacks the i element inside.

And also if I set the same action for both new and form keys, the delete button appears in the new view, which doesn't make sense.

@javiereguiluz
Copy link
Collaborator

I can't reproduce this error.

  1. When using only the edit config:
easy_admin:
    entities:
        MyEntity:
            edit:
                actions: [{ name: 'delete', icon: 'minus-circle' }]

edit_only

  1. When using only the form config:
easy_admin:
    entities:
        MyEntity:
            form:
                actions: [{ name: 'delete', icon: 'minus-square' }]

form_only

  1. When using both the edit and form config:
easy_admin:
    entities:
        MyEntity:
            form:
                actions: [{ name: 'delete', icon: 'minus-square' }]
            edit:
                actions: [{ name: 'delete', icon: 'minus-circle' }]

both

@aruku
Copy link
Author

aruku commented Apr 16, 2015

I was in a hurry and I write it down wrong: there is no need to use both keys (edit and form), just one of them. And I meant when using the default icon for the button, that is, without specifying a custom one like you are doing (using just actions: [delete]). Also, for the second issue, the delete button appearing in the new screen, it doesn't have the FA icon either.

I just checked again and both problems are completely reproducible; I can push a branch if you need it. Also, I just saw that it happens too in the show view.

It looks like it doesn't use the default FA icon when you specify the action but not the icon.

@javiereguiluz
Copy link
Collaborator

@aruku thanks for the explanation. I now fully understand the problem and I can confirm it as a bug. I'm working to fix it.

@javiereguiluz
Copy link
Collaborator

This issue has been fixed in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants