Remove File Type Mismatch Workaround

[rgauss]

See:

• NIST 800-53 JSON Profiles Link to XML Catalogs usnistgov/oscal-content#59

We should remove the workarounds when those issues have been fixed.

[laurelmay]

It looks like the upstream issue has been closed (as the underlying bug has been resolved) but the updated version of the submodule will not be available until usnistgov/oscal-content tags a v1.0.1 release.

[laurelmay]

This has been fixed on the main branch of the project and therefore I am going assign this to a milestone so we can track the work on it. We don't currently reference tagged released upstream anyway and staring at the now mostly dead code for fixJsonUrls just makes me a little sad.

For reference, the workaround to remove is

oscal-react-library/src/components/oscal-utils/OSCALLinkUtils.js

Lines 3 to 12 in 8836913

	export function fixJsonUrls(absoluteUrl) {
	// TODO: This workaround references JSON representation instead of the back-matter links to
	// XML catalogs and it should be removed once the issue has been resolved.
	// https://github.com/EasyDynamics/oscal-react-library/issues/158
	if (!absoluteUrl.endsWith(".xml")) {
	return absoluteUrl;
	}
	// Replacing all instances of xml with json in the path *should* get us the correct json URL
	return absoluteUrl.replace(/xml/g, "json");
	}

All references will need to be updated as well. Anything that tests specifically that function alone (or its behavior of rewriting URLs ending in .xml->.json can be removed); though we should continue to test that functionally all SSPs from oscal-content repository continue to display properly.

[brian-comply0]

@kylelaker Ultimately referencing a XML OSCAL file from a JSON OSCAL file's import statement is valid and should be handled by our tool.

We can't count on every OSCAL file existing in both XML and JSON. Having the tool simply change the ".xml" to ".json" in the file is a fair work-around specifically for the NIST issue.

Ultimately the tool should recognize the XML extension and convert the XML file to JSON, then process it. I suppose as a shortcut, it could look for a JSON version as described in the workaround above before converting; and only convert if no JSON file was found.

In any case, I believe this issue, as written, has been addressed and should be closed. A new issue should cover the more complete functionality.

[brian-comply0]

Closing as discussed with @kylelaker