fix: fetch valid URL for notification items

README.md

@@ -6,7 +6,7 @@ Requires access to a Slack Bot with proper `write` permissions to the Slack chan
 
 Forwarded notifications can be filtered by their [reason](#reason-filtering), [repository](#repository-filtering), [participation](#filter-only-participating), or [read status](#filter-only-unread).
 
-After a notification is forwarded, it can be [marked as read](#mark-as-read)
+After a notification is forwarded, it can be [marked as read](#mark-as-read).
 
 ## TOC
 

dist/index.js

@@ -144,6 +144,7 @@ function run(getCore, getOctokit, getSlack) {
             if (!notifications.length) {
                 return core.info(`No new notifications since last run after running through all filters: ${displayFilters(inputs)}`);
             }
+            // Get the `html_url` for each notification and add it as `notification_html_url`
             notifications = yield Promise.all(notifications.map((notification) => __awaiter(this, void 0, void 0, function* () {
                 var _a;
                 let notification_html_url;
@@ -152,11 +153,8 @@ function run(getCore, getOctokit, getSlack) {
                     notification_html_url = (_a = notificationSubject === null || notificationSubject === void 0 ? void 0 : notificationSubject.data) === null || _a === void 0 ? void 0 : _a.html_url;
                 }
                 catch (error) {
-                    core.warning(`Unable to fetch URL fo notification\mid:${notification.id}\nsubject:${JSON.stringify(notification.subject, null, 2)}`);
+                    core.warning(`Unable to fetch URL for notification\nid:${notification.id}\nsubject:${JSON.stringify(notification.subject, null, 2)}`);
                 }
-                console.log("Item:");
-                console.log(notification.subject);
-                console.log(notification_html_url);
                 return Object.assign(Object.assign({}, notification), { notification_html_url });
             })));
             // Default return is DESC, we want ASC to show oldest first

src/index.test.ts

@@ -46,28 +46,28 @@ function setMockEnv(envMap: { [key: string]: any }) {
 }
 
 function mockGetCore() {
-  const core = {
-    info: sinon.stub().callsFake((args) => console.log(args)),
-    error: sinon.stub().callsFake((args) => console.log(args)),
-    getInput: CoreLibrary.getInput,
-    getBooleanInput: CoreLibrary.getBooleanInput,
-    setFailed: sinon.stub().callsFake((args) => console.log(args)),
-  };
   // const core = {
-    // info: sinon.stub().callsFake((args) => {}),
-    // error: sinon.stub().callsFake((args) => {}),
+    // info: sinon.stub().callsFake((args) => console.log(args)),
+    // error: sinon.stub().callsFake((args) => console.log(args)),
     // getInput: CoreLibrary.getInput,
     // getBooleanInput: CoreLibrary.getBooleanInput,
-    // setFailed: sinon.stub().callsFake((args) => {}),
+    // setFailed: sinon.stub().callsFake((args) => console.log(args)),
   // };
+  const core = {
+    info: sinon.stub().callsFake((args) => {}),
+    error: sinon.stub().callsFake((args) => {}),
+    getInput: CoreLibrary.getInput,
+    getBooleanInput: CoreLibrary.getBooleanInput,
+    setFailed: sinon.stub().callsFake((args) => {}),
+  };
   return () => core;
 }
 
 function mockGetOctokit(
   notifications?: Endpoints["GET /notifications"]["response"]["data"]
 ) {
   const octokit = {
-    request: sinon.stub().resolves((arg) => ({ data: { html_url: `<${arg} html_url>` } })),
+    request: sinon.stub().callsFake(async (arg) => ({ data: { html_url: `<${arg} html_url>` } })),
     rest: {
       activity: {
         listNotificationsForAuthenticatedUser: sinon
@@ -99,6 +99,7 @@ function createMockNotification(title: string, repository: string, reason: REASO
     reason: reason,
     subject: {
       title: title,
+      url: `<subject url for - "${title}">`,
     },
     repository: {
       full_name: repository,
@@ -238,6 +239,9 @@ test("sends slack message of notifications using defaults", async (t) => {
   t.false(octokit.rest.activity.listNotificationsForAuthenticatedUser.getCall(0).args[0].participating);
   t.is(slack.chat.postMessage.callCount, 1);
   t.true(slack.chat.postMessage.getCall(0).args[0].text.includes("<A notification>"));
+
+  // Valid `html_url` fetched via octokit.request()
+  t.true(slack.chat.postMessage.getCall(0).args[0].text.includes(`<<subject url for - "<A notification>"> html_url>`));
 });
 
 test("marks sent notifications as read when mark-as-read is true", async (t) => {

src/index.ts

@@ -144,6 +144,7 @@ async function run(
       );
     }
 
+    // Get the `html_url` for each notification and add it as `notification_html_url`
     notifications = await Promise.all(notifications.map(
       async (
         notification: Endpoints["GET /notifications"]["response"]["data"][0]
@@ -156,14 +157,11 @@ async function run(
           notification_html_url = notificationSubject?.data?.html_url;
         } catch (error) {
           core.warning(
-            `Unable to fetch URL fo notification\mid:${
+            `Unable to fetch URL for notification\nid:${
               notification.id
             }\nsubject:${JSON.stringify(notification.subject, null, 2)}`
           );
         }
-        console.log("Item:");
-        console.log(notification.subject);
-        console.log(notification_html_url);
         return {
           ...notification,
           notification_html_url,