Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing responder_url in a better way #96

Closed
danielgordon-switch-ev opened this issue Aug 4, 2022 · 0 comments · Fixed by #120
Closed

Handle missing responder_url in a better way #96

danielgordon-switch-ev opened this issue Aug 4, 2022 · 0 comments · Fixed by #120

Comments

@danielgordon-switch-ev
Copy link
Contributor

Currently, if the responder_url cannot be obtained from a certificate, we just put "https://www.example.com".

This is probably not reasonable since it just pushes the error elsewhere.

Handle this case in a better way, if possible -- it may be that we can also fall back here on the CSMS retrieving the root certificate, or trying a URL of another certificate in the chain (are these sometimes left out inadvertently in practice?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant