Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depthfirst to TraversalOrder to help with plotting #73

Open
diegozea opened this issue Apr 6, 2022 · 4 comments
Open

Add depthfirst to TraversalOrder to help with plotting #73

diegozea opened this issue Apr 6, 2022 · 4 comments

Comments

@diegozea
Copy link

diegozea commented Apr 6, 2022

That will help when creating Arrays for plotting node attributes, such as adding names/labels to internal nodes.

Cheers

@richardreeve
Copy link
Member

@diegozea - as far as I remember we originally had depth first and breadth first, but then it was pointed out to me that there were three kinds of depth first ordering, preorder (which is what I always used to call depth first), inorder and postorder. There's a description of them here, for instance. Is preorder what you meant? If so, is that okay?

What we definitely need is documentation for that enum though!

@diegozea
Copy link
Author

diegozea commented Apr 7, 2022

Hi @richardreeve ! I have tried the three, pre, in, and post order, and they don't match the node depth first order used for plotting. It looks like plotting and map_depthfirst are using some of the reverse orderings; is that possible?

@mkborregaard
Copy link
Member

I intended plotting to use preorder but might have implemented it wrong

@richardreeve
Copy link
Member

Or I might have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants