fix: throw Error that dynamic menus only can handle buttons

EdJoPaTo · Sep 21, 2018 · 39b335b · 39b335b
1 parent 9cb222a
commit 39b335b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/inline-menu.js b/inline-menu.js
@@ -117,6 +117,10 @@ class TelegrafInlineMenu {
       if (this.commands.length > 0) {
         throw new Error('commands can not point on dynamic submenus. Happened in menu ' + actionCode.get() + ' with the following commands: ' + this.commands.join(', '))
       }
+      const handlerNotActions = this.handlers.filter(o => !o.action)
+      if (handlerNotActions.length > 0) {
+        throw new Error('a dynamic submenu can only contain buttons. A question for example does not work. Happened in menu ' + actionCode.get())
+      }
     }
 
     options.log('middleware triggered', actionCode.get(), options, this)

diff --git a/test/select.submenu.js b/test/select.submenu.js
@@ -90,3 +90,19 @@ test('hide dynamic submenu does not work', t => {
     })
   }, /dynamic/)
 })
+
+test('something that is not an action in dynamic menu throws error', t => {
+  const menu = new TelegrafInlineMenu('foo')
+  const submenu = new TelegrafInlineMenu('bar')
+    .question('Question', 'q', {
+      questionText: '42',
+      setFunc: () => {}
+    })
+  menu.select('a', ['a', 'b'], {
+    submenu
+  })
+  const bot = new Telegraf()
+  t.throws(() => {
+    bot.use(menu.init())
+  }, /dynamic.+question.+menu.+a/)
+})