Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add min date for milestone #9060

Merged

Conversation

Giuliano1993
Copy link
Contributor

Fixes Issue

Closes #8926

Changes proposed

  • added a front-end control in input field as min date
  • added a backend control in milestone schema with min date

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • [] I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I added as min date 01-01-1950 as it seemed a reasonable limit to me, but can be changed if is not good enough

@github-actions github-actions bot added models issue linked Pull Request has issue linked labels Sep 13, 2023
Copy link
Member

@accodes21 accodes21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 👍

Why 1950 as the min date? Maybe 1970 is better?

@Giuliano1993
Copy link
Contributor Author

Yeah @eddiejaoude probably 1970 will be better; 1950 was actually still way too back! Gonna change it in a moment!

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you 👍

@eddiejaoude eddiejaoude merged commit f7e5c65 into EddieHubCommunity:main Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] need to add some control to the Milestone date field
3 participants