Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: heading strucuture fails WCAG 2.2AA (#9631) #9719

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Conversation

eddiejaoude
Copy link
Member

@eddiejaoude eddiejaoude commented Nov 3, 2023

closes #9581

Fix PR #9631

Restructure the document headings in DataList.js to ensure that heading levels are not skipped.

  • issue fix #9581_ heading structure fails WCAG 2.2AA- skipped heading

changed all

to


Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

* issue fix #9581: heading strrucutre fails WCAG 2.2AA- skipped heading level

Restructure the document headings in DataList.js to ensure that heading levels are not skipped.

* issue fix #9581_ heading structure fails WCAG 2.2AA- skipped heading

changed all <h3> to <h2>

---------

Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
@github-actions github-actions bot added the tests label Nov 3, 2023
@github-actions github-actions bot added the tests label Nov 8, 2023
@eddiejaoude eddiejaoude merged commit ba6ea4f into main Nov 8, 2023
@eddiejaoude eddiejaoude deleted the fix-pr-9631 branch November 8, 2023 13:48
malay44 pushed a commit to malay44/BioDrop that referenced this pull request Nov 9, 2023
…dieHubCommunity#9719)

* fix: heading strucuture fails WCAG 2.2AA (EddieHubCommunity#9631)

* issue fix EddieHubCommunity#9581: heading strrucutre fails WCAG 2.2AA- skipped heading level

Restructure the document headings in DataList.js to ensure that heading levels are not skipped.

* issue fix #9581_ heading structure fails WCAG 2.2AA- skipped heading

changed all <h3> to <h2>

---------

Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>

* fix: undo file changes

* fix: failing tests

* fix: search tests for h2 changes

---------

Co-authored-by: Jen <73888356+berryjen@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Heading structure fails WCAG 2.2 AA - Skipped heading level
2 participants