Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

feat: revamp homepage (#1264) #1341

Merged
merged 6 commits into from
Jun 1, 2022
Merged

feat: revamp homepage (#1264) #1341

merged 6 commits into from
Jun 1, 2022

Conversation

eddiejaoude
Copy link
Member

@eddiejaoude eddiejaoude commented May 30, 2022

Fixes Issue

closes #1264

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot_2022-05-30_at_19 40 01

Note to reviewers

Sorry, something went wrong.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

src/Components/Home.js Outdated Show resolved Hide resolved
@eddiejaoude eddiejaoude requested a review from naomi-lgbt May 31, 2022 07:05
Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice and responsive. I've just picked up a couple of small things that could be improved.

__
sema-logo  Summary: 👌 This code looks good

src/Components/Home.js Outdated Show resolved Hide resolved
src/Components/Home.js Outdated Show resolved Hide resolved
<>
<Navbar
start={
<Link to="/search" aria-label="Search">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the search icon is a link it turns blue once visited. Is that something we want?

__
sema-logo  Summary: ❓ I have a question  |  Tags: Inefficient

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this the same as it was before (similar to the back button on the profile page)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be improved 👍 , but I think these changes can come in another PR

Copy link
Contributor

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and get this in and deployed.

@naomi-lgbt naomi-lgbt merged commit da767e0 into main Jun 1, 2022
@eddiejaoude eddiejaoude deleted the issue-1264 branch June 1, 2022 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Revamp Home Page
5 participants