Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

profile: add loftwah profile #1428

Merged
merged 3 commits into from
Jul 1, 2022
Merged

profile: add loftwah profile #1428

merged 3 commits into from
Jul 1, 2022

Conversation

loftwah
Copy link
Member

@loftwah loftwah commented Jul 1, 2022

Changes proposed

  • add an icon for Spotify
  • add loftwah profile

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

I hope I have done this properly. You are awesome Eddie!

Sorry, something went wrong.

loftwah added 2 commits July 1, 2022 19:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

src/config/links.json Outdated Show resolved Hide resolved
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just 1 small comment

@loftwah
Copy link
Member Author

loftwah commented Jul 1, 2022

It was the Prettier plugin that cut the line, I had it on auto-format on save. Let me know if it is still off, I am used to working with yaml more than json.

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eddiejaoude eddiejaoude merged commit 7128a78 into EddieHubCommunity:main Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants