Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

feat: Migration to NextJs #1556

Merged
merged 3 commits into from
Aug 3, 2022
Merged

feat: Migration to NextJs #1556

merged 3 commits into from
Aug 3, 2022

Conversation

JealousGx
Copy link
Member

@JealousGx JealousGx commented Aug 2, 2022

Fixes Issue

fixes #1470

Changes proposed

  • Modified home page.
  • Fixed bugs that prevented the deployment.
  • Minor UI Changes in the Search tab.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[] My change requires changes to the documentation.
[] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@eddiejaoude
Copy link
Member

Thank you @JealousGx 👍 this is a big PR, is it possible to break it into smaller PRs?

@JealousGx
Copy link
Member Author

Thank you @JealousGx 👍 this is a big PR, is it possible to break it into smaller PRs?

@eddiejaoude Done. I have broken down the skeleton PR and homepage with some bug fixes into two PRs. Let me know if anything else needs to be fixed in these PRs.

@schmelto schmelto changed the title Feature: Migration to NextJs feat: Migration to NextJs Aug 3, 2022
@eddiejaoude
Copy link
Member

Great! Thank you! Let me take a look 👍

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@eddiejaoude eddiejaoude merged commit bd15d7b into EddieHubCommunity:nextjs Aug 3, 2022
@JealousGx JealousGx deleted the feat/home branch August 3, 2022 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants