Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

added my links #1609

Merged
merged 10 commits into from
Sep 2, 2022
Merged

added my links #1609

merged 10 commits into from
Sep 2, 2022

Conversation

viktorCodes
Copy link
Contributor

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@kumarsonsoff3 kumarsonsoff3 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Aug 15, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in the package.json and .gitignore files. Let us know if you need any help with that. Thank you. 😄

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Not maintainable

}
,
{
"name": "Follow me on Linkedin",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend capitalizing the i here. What do you think?

Suggested change
"name": "Follow me on Linkedin",
"name": "Follow me on LinkedIn",

__
sema-logo  Summary: ❓ I have a question

@EmmaDawsonDev
Copy link
Member

Do you need any help making the requested changes @viktorCodes ?

@viktorCodes
Copy link
Contributor Author

Do you need any help making the requested changes @viktorCodes ?

Yes I do.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Aug 31, 2022
@github-actions
Copy link
Contributor

Welcome @viktorCodes! Thank you so much for your first pull request!

capitalized 'I' in LinkedIn
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 3 Files needed changes

  • Remove the empty endline from package.json file!
  • Make the changes as suggested below!

__
sema-logo  Summary: 🛠️ This code needs a fix

.gitignore Outdated Show resolved Hide resolved
public/data/viktorCodes.json Outdated Show resolved Hide resolved
@EddieHubCommunity EddieHubCommunity deleted a comment from github-actions bot Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Reviewpad Report

ℹ️ Messages

  • A maintainer will review your pull request soon!

@github-actions github-actions bot added the LGTM label Sep 2, 2022
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully good to go now! 👍

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Elegant

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eddiejaoude eddiejaoude merged commit 5de1e3b into EddieHubCommunity:main Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants