Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Generate list on app start #168

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Generate list on app start #168

merged 2 commits into from
Sep 14, 2021

Conversation

eddiejaoude
Copy link
Member

@eddiejaoude eddiejaoude commented Sep 14, 2021

Fixes #

List file is now generated on app start

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with the Gitpod-Link
LGTM 👍

@eddiejaoude
Copy link
Member Author

Thank you! I just hope it works when deployed 😂

@eddiejaoude eddiejaoude merged commit e4fdb73 into main Sep 14, 2021
@eddiejaoude eddiejaoude deleted the generate-list branch September 14, 2021 07:59
@Cahllagerfeld
Copy link
Member

Cahllagerfeld commented Sep 14, 2021

One thing:

when deploying the built version, we dont run the start script.
Maybe it needs to be run in the prebuild hook as well

Unfortunaltey because of the DNS I cant test it from here :(.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants